[ 
https://issues.apache.org/jira/browse/SCM-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17960059#comment-17960059
 ] 

ASF GitHub Bot commented on SCM-50:
-----------------------------------

jira-importer commented on issue #313:
URL: https://github.com/apache/maven-scm/issues/313#issuecomment-2964585026

   **[Emmanuel 
Venisse](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=evenisse)**
 commented
   
   all commands methods will be in ScmProvider. For obtain correct signature, 
each command must return a specific ScmResult.
   Actually all command implements the executeCommand method that return 
ScmResult, so we need to refactor all command and implements a specific 
interface by command and remove the executeCommand in Command interface
   
   For checkout, we'll do manager.getProvider().checkout(...)
   




> flesh out the SCM provider interface
> ------------------------------------
>
>                 Key: SCM-50
>                 URL: https://issues.apache.org/jira/browse/SCM-50
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Task
>          Components: maven-scm-api
>            Reporter: Brett Porter
>            Assignee: Emmanuel Venisse
>            Priority: Major
>             Fix For: 1.0-alpha-2
>
>
> instead of having an execute() method, the ScmProvider interface should have 
> individual commands in the interface, like ScmManager currently does.
> In fact, after this, the ScmManager need not have the commands, and just 
> needs to expose a getProvider method.
> This should eventually lead to the removal of CommandNameConstants



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to