[ 
https://issues.apache.org/jira/browse/SCM-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17960296#comment-17960296
 ] 

ASF GitHub Bot commented on SCM-72:
-----------------------------------

jira-importer commented on issue #372:
URL: https://github.com/apache/maven-scm/issues/372#issuecomment-2964590169

   **[David 
Hawkins](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=dhawkins)**
 commented
   
   Added automatic tag resolution to SvnCheckoutCommand, SvnChangeLogCommand, 
and SvnTagCommand.
   
   On the SvnChangeLogCommand command, I changed the date format specified in 
the command line.
   The original format looked like: svn log -v -r "{2003/09/10 GMT}:{2003/10/10 
GMT}"
   But this format was not legal in svn version 1.2.3 on cygwin, linux, or 
windows.  I am not sure if a previous version supported this date format, but 
the current does not.
   The new date format looks like: svn log -v -r "{2003-09-10 00:00:00 
+0000}:{2003-10-10 00:00:00 +0000}"
   It is now specifying the time along with the date. The api allows  a user to 
pass a date, so we should probably use the time in the date as well.
   I also changed ScmTestCase.getDate() to support passing time values so I 
could test the changelog command creation.
   
   As far as SvnDiffCommand goes, I didn't add branch/tag resolution to it 
because the api specifies a "startRevision" and "endRevision".  While it might 
be useful to be able to support tag/branch diffs, the api only specifies 
revisions.  This is something that can always be added at a later date if 
deemed necessary.
   
   It also seems odd to me that the StatusMojo doesn't actually print anything 
out.  It has a StatusScmResult with a list of changed files, but only checks 
that the result was successful.  Maybe I don't understand the intended use of 
the action, but it basically throws away the result without ever doing anything 
with it.
   




> Remove tagbase usage and use insted mecanism use in update command
> ------------------------------------------------------------------
>
>                 Key: SCM-72
>                 URL: https://issues.apache.org/jira/browse/SCM-72
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Task
>          Components: maven-scm-provider-svn
>    Affects Versions: 1.0-beta-1
>            Reporter: Emmanuel Venisse
>            Assignee: Emmanuel Venisse
>            Priority: Major
>             Fix For: 1.0-beta-1
>
>         Attachments: SCM-72-maven-scm-test.patch, 
> SCM-72-maven.scm-provider-svn.patch
>
>
> David Hawkins, do you want work on it?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to