[
https://issues.apache.org/jira/browse/SCM-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17960593#comment-17960593
]
ASF GitHub Bot commented on SCM-191:
------------------------------------
jira-importer opened a new issue, #430:
URL: https://github.com/apache/maven-scm/issues/430
**[Thibaut
CAZENAVE](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=thibautcazenave)**
opened
**[SCM-191](https://issues.apache.org/jira/browse/SCM-191?redirect=false)** and
commented
1st bug :
The system property -Dmaven.scm.cvs.use_compression=false doesn't work if
getSettings() method of CvsUtil class doesn't find the cvs-settings.xml file.
In this case, this method return a new Settings() for which
compressionLevel=3 (constructor of Settings class).
In method getBaseCommand() of CvsCommandUtils class
(org.apache.maven.scm.provider.cvslib.command), since
settings.getCompressionLevel() = 3, if condition is true and then it adds -z3
to CommandLine cl.
2nd bug :
If you set \<compressionLevel>0\</compressionLevel> in cvs-settings.xml
without setting system property -Dmaven.scm.cvs.use_compression=false, -z3 cvs
compression is used.
In method getBaseCommand(), since settings.getCompressionLevel() > 0, if
condition is false and then we go in else if condition (!System.getProperty(
"maven.scm.cvs.use_compression", "true" ).equals( "false" )) which happens to
be true so it adds -z3 to CommandLine cl.
Patch proposed :
Replace in CvsCommandUtils getBaseCommand() method :
---
if ( settings.getCompressionLevel() > 0 )
{
cl.createArgument().setValue( "-z" + settings.getCompressionLevel() );
}
else if ( !System.getProperty( "maven.scm.cvs.use_compression", "true"
).equals( "false" ) )
{
cl.createArgument().setValue( "-z3" );
}
---
with :
---
if (settings.getCompressionLevel() > 0 &&
System.getProperty("maven.scm.cvs.use_compression", "true").equals("true"))
cl.createArgument().setValue("-z" + settings.getCompressionLevel());
---
Tibo
---
**Affects:** 1.0-beta-3
> Difficult to disable cvs compress mode using system property
> -Dmaven.scm.cvs.use_compression=false and cvs-settings.xml property file
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SCM-191
> URL: https://issues.apache.org/jira/browse/SCM-191
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-cvs
> Affects Versions: 1.0-beta-3
> Reporter: Thibaut CAZENAVE
> Assignee: Emmanuel Venisse
> Priority: Minor
> Fix For: 1.0-beta-4
>
>
> 1st bug :
> The system property -Dmaven.scm.cvs.use_compression=false doesn't work if
> getSettings() method of CvsUtil class doesn't find the cvs-settings.xml file.
> In this case, this method return a new Settings() for which
> compressionLevel=3 (constructor of Settings class).
> In method getBaseCommand() of CvsCommandUtils class
> (org.apache.maven.scm.provider.cvslib.command), since
> settings.getCompressionLevel() = 3, if condition is true and then it adds
> -z3 to CommandLine cl.
> 2nd bug :
> If you set <compressionLevel>0</compressionLevel> in cvs-settings.xml without
> setting system property -Dmaven.scm.cvs.use_compression=false, -z3 cvs
> compression is used.
> In method getBaseCommand(), since settings.getCompressionLevel() > 0, if
> condition is false and then we go in else if condition (!System.getProperty(
> "maven.scm.cvs.use_compression", "true" ).equals( "false" )) which happens to
> be true so it adds -z3 to CommandLine cl.
> Patch proposed :
> Replace in CvsCommandUtils getBaseCommand() method :
> ---------------------
> if ( settings.getCompressionLevel() > 0 )
> {
> cl.createArgument().setValue( "-z" +
> settings.getCompressionLevel() );
> }
> else if ( !System.getProperty( "maven.scm.cvs.use_compression",
> "true" ).equals( "false" ) )
> {
> cl.createArgument().setValue( "-z3" );
> }
> ---------------------
> with :
> ---------------------
> if (settings.getCompressionLevel() > 0 &&
> System.getProperty("maven.scm.cvs.use_compression", "true").equals("true"))
> cl.createArgument().setValue("-z" + settings.getCompressionLevel());
> --------------------
> Tibo
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
