[
https://issues.apache.org/jira/browse/SCM-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17960583#comment-17960583
]
ASF GitHub Bot commented on SCM-168:
------------------------------------
jira-importer opened a new issue, #428:
URL: https://github.com/apache/maven-scm/issues/428
**[John
Didion](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jdidion)**
opened
**[SCM-168](https://issues.apache.org/jira/browse/SCM-168?redirect=false)** and
commented
It seems like all scm providers are dealing with relative paths, rather than
absolute repository paths. PerforceCheckOutCommand is definitely doing this.
PerforceChangeLogConsumer, however, does not, which means
ChangeSet.containsFilename always returns false because it's comparing a
relative path to an absolute one.
There are two changes. First, in PerforceChangeLogCommand:
```
PerforceChangeLogConsumer consumer = new PerforceChangeLogConsumer(
((PerforceScmProviderRepository) repo).getPath(), startDate, endDate );
```
The attached diff is for the second set of changes, which are to
PerforceChangeLogConsumer.
---
**Affects:** 1.0-beta-3
**Attachments:**
-
[PerforceChangeLogConsumer.diff](https://issues.apache.org/jira/secure/attachment/12718876/PerforceChangeLogConsumer.diff)
(_493 bytes_)
> PerforceChangeLogConsumer should use relative paths
> ---------------------------------------------------
>
> Key: SCM-168
> URL: https://issues.apache.org/jira/browse/SCM-168
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.0-beta-3
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Fix For: 1.0-beta-3
>
> Attachments: PerforceChangeLogConsumer.diff
>
>
> It seems like all scm providers are dealing with relative paths, rather than
> absolute repository paths. PerforceCheckOutCommand is definitely doing this.
> PerforceChangeLogConsumer, however, does not, which means
> ChangeSet.containsFilename always returns false because it's comparing a
> relative path to an absolute one.
> There are two changes. First, in PerforceChangeLogCommand:
> {noformat}
> PerforceChangeLogConsumer consumer = new PerforceChangeLogConsumer(
> ((PerforceScmProviderRepository) repo).getPath(), startDate, endDate );
> {noformat}
> The attached diff is for the second set of changes, which are to
> PerforceChangeLogConsumer.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
