jira-importer commented on issue #482:
URL: https://github.com/apache/maven-scm/issues/482#issuecomment-2964598263

   **[Richard van der 
Hoff](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=richvdh)** 
commented
   
   evenisse and I had a fairly lengthy chat about this on #maven last week. It 
seems that just making this change may well break backwards compatibility with 
cvsnt.
   
   The current behaviour is certainly wrong, as it passes a quoted argument to 
System.exec(String[]). Under linux, the argument is passed straight through, 
without further modification, to the OS and thence to the cvs binary. Under 
Windows, if memory serves correctly, the String[] array is first joined into a 
single command line, and then split again by the cvs binary - this extra stage 
of joining/splitting allows the current broken behaviour to go unnoticed.
   
   That doesn't detract from the fact that the fix was put in, deliberately, to 
make the changelog command work with cvsnt. Without a windows development 
system handy, it's difficult for me to be exactly certain why it is needed. I 
suspect the problem lies with cvsnt (implying that the fix should stay in 
maven-scm-provider-cvs, modified to somehow not break linux - a slightly fudgy 
test of os.name may well be adequate) but it may also be in System.exec 
(suggesting a workaround is needed in plexus-cli), or somewhere else again.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to