[
https://issues.apache.org/jira/browse/SCM-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963629#comment-17963629
]
ASF GitHub Bot commented on SCM-907:
------------------------------------
jira-importer opened a new issue, #1138:
URL: https://github.com/apache/maven-scm/issues/1138
**[Michael
Osipov](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michael-o)**
opened
**[SCM-907](https://issues.apache.org/jira/browse/SCM-907?redirect=false)** and
commented
This issue was been found on one of Jenkins slaves. Consider the following
path:
`F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_SCM-906-3AXCXWOA5KAAL37TCEKGJUQCHVU3HMOGCVV63JP76C24C3X6DHOA@2\m\maven-scm-providers\maven-scm-providers-git\maven-scm-provider-gitexe\target`.
THe aforementioned class outputs:
```
file:///F:/jenkins/jenkins-slave/workspace/maven-box_maven-scm_SCM-906-3AXCXWOA5KAAL37TCEKGJUQCHVU3HMOGCVV63JP76C24C3X6DHOA@2/m/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/target
file://2/m/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/target
```
The parse logic incorrectly assumes that the last `@` is for the user info.
According to RFC 8089 a file URL may contain this information, but our parser
would still fail becuase it uses `lastIndexOf`. It must stop searching to the
first slash.
---
**Affects:** 1.10.0
**Sub-tasks:**
- [SCM-908](https://issues.apache.org/jira/browse/SCM-908)
GitScmProviderRepository#parseUrl(): skip parsing of user info for file:// URLs
> GitScmProviderRepository#parseUrl() does not comply with RFC 3986 and RFC 8089
> ------------------------------------------------------------------------------
>
> Key: SCM-907
> URL: https://issues.apache.org/jira/browse/SCM-907
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-gitexe, maven-scm-provider-jgit
> Affects Versions: 1.10.0
> Reporter: Michael Osipov
> Priority: Major
>
> This issue was been found on one of Jenkins slaves. Consider the following
> path:
> {{F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_SCM-906-3AXCXWOA5KAAL37TCEKGJUQCHVU3HMOGCVV63JP76C24C3X6DHOA@2\m\maven-scm-providers\maven-scm-providers-git\maven-scm-provider-gitexe\target}}.
> THe aforementioned class outputs:
> {noformat}
> file:///F:/jenkins/jenkins-slave/workspace/maven-box_maven-scm_SCM-906-3AXCXWOA5KAAL37TCEKGJUQCHVU3HMOGCVV63JP76C24C3X6DHOA@2/m/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/target
> file://2/m/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/target
> {noformat}
> The parse logic incorrectly assumes that the last {{@}} is for the user info.
> According to RFC 8089 a file URL may contain this information, but our parser
> would still fail becuase it uses {{lastIndexOf}}. It must stop searching to
> the first slash.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
