[
https://issues.apache.org/jira/browse/SCM-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17960444#comment-17960444
]
ASF GitHub Bot commented on SCM-106:
------------------------------------
jira-importer opened a new issue, #403:
URL: https://github.com/apache/maven-scm/issues/403
**[Dennis
Lundberg](https://issues.apache.org/jira/secure/[email protected])**
opened
**[SCM-106](https://issues.apache.org/jira/browse/SCM-106?redirect=false)** and
commented
I am trying out Continuum and am tracking down the cause of why I get an
error regarding the scm url that I provide when adding an ant project. This has
led me here. I copied the scm url from my maven 1 project.xml and got a very
breif error message telling me to enter a valid scm url.
My scm url looks like this:
scm|cvs|pserver|user@localhost|C:/Program/cvsnt/repositories|project-name
This works just fine using maven 1.
These two files are involved in this:
maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java
maven-scm-site/src/site/apt/cvs.apt
AbstractScmManager.java has the following error message declared:
private final static String ILLEGAL_SCM_URL = "The scm url must be on
the form "
+ "'scm:<scm
provider><delimiter><provider specific part>' "
+ "where <delimiter> can
be either ':' or '|'.";
which explains how a correct scm url should look.
cvs.apt on the other hand does not have this explanation. It does say:
For all URLs below, we use a colon (:) as separator. If you use a colon for
one of the variables (e.g. a windows path), then use a pipe (|) as separator.
Then follows a bunch of examples, none of which use pipe (|) as a separator.
So to conclude: Continuum uses validateScmRepository(String scmUrl) and
maven scm flags my scm url as invalid, but the docs for the urls are not really
clear about what a delimiter/separator is and where they are in the scm url.
Asuming that the source code is correct, the the docs need updating to
reflect this. There should also be an example using pipe as a separator. If
someone can confirm this I can write a patch for the docs.
---
**Attachments:**
-
[SCM-106.patch](https://issues.apache.org/jira/secure/attachment/12718778/SCM-106.patch)
(_1.73 kB_)
-
[SCM-106-2.patch](https://issues.apache.org/jira/secure/attachment/12718488/SCM-106-2.patch)
(_3.04 kB_)
**Issue Links:**
- [SCM-1](https://issues.apache.org/jira/browse/SCM-1) Publish site for 1.0
> Validation of scm url fails because of ambiquities between source code and
> site documentation
> ---------------------------------------------------------------------------------------------
>
> Key: SCM-106
> URL: https://issues.apache.org/jira/browse/SCM-106
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-api
> Reporter: Dennis Lundberg
> Assignee: Emmanuel Venisse
> Priority: Major
> Fix For: 1.0-beta-3
>
> Attachments: SCM-106-2.patch, SCM-106.patch
>
>
> I am trying out Continuum and am tracking down the cause of why I get an
> error regarding the scm url that I provide when adding an ant project. This
> has led me here. I copied the scm url from my maven 1 project.xml and got a
> very breif error message telling me to enter a valid scm url.
> My scm url looks like this:
> scm|cvs|pserver|user@localhost|C:/Program/cvsnt/repositories|project-name
> This works just fine using maven 1.
> These two files are involved in this:
> maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java
> maven-scm-site/src/site/apt/cvs.apt
> AbstractScmManager.java has the following error message declared:
> private final static String ILLEGAL_SCM_URL = "The scm url must be on the
> form "
> + "'scm:<scm
> provider><delimiter><provider specific part>' "
> + "where <delimiter> can be
> either ':' or '|'.";
> which explains how a correct scm url should look.
> cvs.apt on the other hand does not have this explanation. It does say:
> For all URLs below, we use a colon (:) as separator. If you use a colon for
> one of the variables (e.g. a windows path), then use a pipe (|) as separator.
> Then follows a bunch of examples, none of which use pipe (|) as a separator.
> So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven
> scm flags my scm url as invalid, but the docs for the urls are not really
> clear about what a delimiter/separator is and where they are in the scm url.
> Asuming that the source code is correct, the the docs need updating to
> reflect this. There should also be an example using pipe as a separator. If
> someone can confirm this I can write a patch for the docs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
