[jira] [Commented] (SCM-950) Passing file as key to a map of strings

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/SCM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963786#comment-17963786
 ] 

ASF GitHub Bot commented on SCM-950:
------------------------------------

jira-importer opened a new issue, #1180:
URL: https://github.com/apache/maven-scm/issues/1180

   **[Elliotte Rusty 
Harold](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=elharo)** 
opened 
**[SCM-950](https://issues.apache.org/jira/browse/SCM-950?redirect=false)** and 
commented
   
   Line 95 in BazaarUpdateCommand passes the wrong type as a key:
   
   `}}{{ Map<String, CharSequence> diffChanges = diffConsumer.getDifferences();`
   ` for ( Iterator<ScmFile> it = diffFiles.iterator(); it.hasNext(); )`
   ` {`
   ` ScmFile file = it.next();`
   ` changes.add( diffChanges.get( file ) );`
   ` if ( file.getStatus() == ScmFileStatus.MODIFIED )`
   ` {`
   ` updatedFiles.add( new ScmFile( file.getPath(), ScmFileStatus.PATCHED ) );`
   ` `}
   ` else`
   ` {`
   ` updatedFiles.add( file );`
   ` `}
   ` `}
   
   
   ---
   No further details from 
[SCM-950](https://issues.apache.org/jira/browse/SCM-950?redirect=false)




> Passing file as key to a map of strings
> ---------------------------------------
>
>                 Key: SCM-950
>                 URL: https://issues.apache.org/jira/browse/SCM-950
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>            Reporter: Elliotte Rusty Harold
>            Priority: Major
>
> Line 95 in BazaarUpdateCommand passes the wrong type as a key:
> {{}}{{ Map<String, CharSequence> diffChanges = 
> diffConsumer.getDifferences();}}
> {{ for ( Iterator<ScmFile> it = diffFiles.iterator(); it.hasNext(); )}}
> {{ {}}
> {{ ScmFile file = it.next();}}
> {{ changes.add( diffChanges.get( file ) );}}
> {{ if ( file.getStatus() == ScmFileStatus.MODIFIED )}}
> {{ {}}
> {{ updatedFiles.add( new ScmFile( file.getPath(), ScmFileStatus.PATCHED ) );}}
> {{ }}}
> {{ else}}
> {{ {}}
> {{ updatedFiles.add( file );}}
> {{ }}}
> {{ }}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)