[
https://issues.apache.org/jira/browse/SCM-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963745#comment-17963745
]
ASF GitHub Bot commented on SCM-939:
------------------------------------
jira-importer commented on issue #1165:
URL: https://github.com/apache/maven-scm/issues/1165#issuecomment-2964649580
**[Niels
Basjes](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=nielsbasjes)**
commented
My current assessment is that I cannot fix this simply 'in' this project
without effectively copying the entire
https://github.com/apache/maven-plugin-testing in here too.
The main problems I have bumped into
* Because the tests all must extend AbstractMojoTestCase I cannot simply
extend them from both classes.
* Some methods need to be overridden in AbstractMojoTestCase but they are
final
* Some methods (like setupContainer()) can be overridden but the output is
NOT a value. The output is directly written to a local property.
So right now I see 3 viable routes (I assume there are more):
* Change https://github.com/apache/maven-plugin-testing to support Junit 4
(5?)
* Copy much of https://github.com/apache/maven-plugin-testing into maven-scm
and go from there
* Use reflection to forcefully overwrite/override what needs to be changed.
Please advise on hoe to proceed [Michael
Osipov](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michael-o)
> Assume SCM is present
> ---------------------
>
> Key: SCM-939
> URL: https://issues.apache.org/jira/browse/SCM-939
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Reporter: Elliotte Rusty Harold
> Assignee: Michael Osipov
> Priority: Minor
> Fix For: 2.1.0
>
>
> We have a lot of tests that do something like this:
>
> if ( !ScmTestCase.isSystemCmd( SvnScmTestUtils.SVN_COMMAND_LINE ) )
> {
> ScmTestCase.printSystemCmdUnavail( SvnScmTestUtils.SVN_COMMAND_LINE,
> getName() );
> return;
> }
>
> We should instead use org.*junit*.*Assume* here so these are marked as
> skipped rather than passed.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
