gnodet commented on PR #1274: URL: https://github.com/apache/maven-javadoc-plugin/pull/1274#issuecomment-3414218756
> The [d2dd532](https://github.com/apache/maven-javadoc-plugin/commit/d2dd5321dc02e793d87c722224c40d94a607cb51) brought an inconsistency that I saw with a project containing chinese characters and I made it consistent with [33c9f01](https://github.com/apache/maven-javadoc-plugin/commit/33c9f01af9a3d4d28decbabd0bc02c4b3a875c2d) > > I assume that this bug comes from something related to the way we are determining the charset in that getDataCharset function. It might be needed to make the decision making depending not only on java version but also on os/arch. > > I will test this fix. If it is not making the previous bug come back, we can just leave it as it is, but if it regresses, we should look for a proper fix. @slachiewicz have a look at https://issues.apache.org/jira/browse/MJAVADOC-614, it mentions the intent for the JDK check, and the fact that the @-files is using UTF-8 on JDK 9..12 and `Charset.defaultSet()` on others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
