Copilot commented on code in PR #149: URL: https://github.com/apache/maven-release/pull/149#discussion_r2507274924
########## maven-release-plugin/src/it/projects/perform/MRELEASE-839/pom.xml: ########## @@ -0,0 +1,47 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. + --> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.maven.plugin.release.its</groupId> + <artifactId>mrelease-832</artifactId> Review Comment: The artifact ID should be `mrelease-839` to match the issue number and directory name (MRELEASE-839), but it's currently set to `mrelease-832` which appears to be a copy-paste error from the MRELEASE-832 test. ```suggestion <artifactId>mrelease-839</artifactId> ``` ########## maven-release-plugin/src/test/java/org/apache/maven/plugins/release/stubs/MavenProjectStub.java: ########## @@ -49,6 +50,26 @@ public Model getModel() return model; } Review Comment: This method overrides [MavenProjectStub.getScm](1); it is advisable to add an Override annotation. ```suggestion @Override ``` ########## maven-release-plugin/src/test/java/org/apache/maven/plugins/release/PerformReleaseMojoTest.java: ########## @@ -78,6 +83,8 @@ public void testPerform() assertNotNull( argument.getValue().getReleaseEnvironment() ); assertNotNull( argument.getValue().getReactorProjects() ); assertEquals( Boolean.FALSE, argument.getValue().getDryRun() ); + assertNotNull( argument.getValue().getReleaseDescriptorBuilder() ); Review Comment: Duplicate assertion. Line 82 already contains `assertNotNull( argument.getValue().getReleaseDescriptorBuilder() );`. This duplicate assertion should be removed. ```suggestion ``` ########## maven-release-plugin/src/test/java/org/apache/maven/plugins/release/stubs/MavenProjectStub.java: ########## @@ -49,6 +50,26 @@ public Model getModel() return model; } + public Scm getScm() + { + Scm scm = new Scm(); + scm.setConnection( "scm:svn:file://localhost/target/svnroot/flat-multi-module/trunk/root-project" ); + + return scm; + } + Review Comment: This method overrides [MavenProjectStub.getOriginalModel](1); it is advisable to add an Override annotation. ```suggestion @Override ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
