gnodet commented on PR #991: URL: https://github.com/apache/maven-compiler-plugin/pull/991#issuecomment-3527239089
> _**Edit:** a previous version of this pull request wrongly said that this issue exists since Maven core 4.0.0-rc-5. However after verification, it seems that [apache/maven#2505](https://github.com/apache/maven/pull/2505) has never been ported to the 4.0.x branch._ > > Since Maven core 4.1.0-SNAPSHOT, options formatted by `JavaPathType` have file names between quotes ([apache/maven#2505](https://github.com/apache/maven/pull/2505)). This is desired for producing robust `target/javac.args` files allowing users to reproduce a compilation. However, the compiler plugin also has a `WorkaroundForPatchModule` class because (as of Java 24) `JavaFileManager` does not accept `StandardLocation.PATCH_MODULE_PATH` in calls to `setLocationForModule(…)`. That workaround expect file names without quotes. Therefore, the quotes added by Maven core needs to be removed. > > Note: it does not necessarily means that Maven core should be modified, because `WorkaroundForPatchModule` is really (as its name implies) a workaround for a problem that should not exist. Would it be better to backport #2505 ? Or should the java compiler add the quotes maybe ? Related to #11435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
