elharo commented on code in PR #1441:
URL: https://github.com/apache/maven-release/pull/1441#discussion_r2572595797
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java:
##########
@@ -113,7 +113,7 @@ public void executeGoals(
targetGoals.add(additionalArguments);
}
- req.setGoals(targetGoals);
+ req.addArgs(targetGoals);
Review Comment:
This is what the deprecation message says:
```
/**
* Sets the goals for the Maven invocation.
*
* @param goals The goals for the Maven invocation, may be
<code>null</code> to execute the POMs default goal.
* @return This invocation request.
* @deprecated simply {@link #addArg(String)} or {@link
#addArgs(Collection)} should be used
*/
```
Is that wrong then? Should this method be undeprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
