mattjohnson opened a new pull request, #430:
URL: https://github.com/apache/maven-build-cache-extension/pull/430
Add support for POSIX symlinks in zip/unzip operations, preserving symlink
targets when caching directory outputs. This enables caching of directories
containing symlinks (e.g., node_modules with pnpm).
Performance improvements for large directory caching:
- Use ParallelScatterZipCreator for multi-threaded compression
- Use BEST_SPEED compression level for faster processing
- Skip compression (STORED method) for already-compressed file types (.gz,
.tgz, .zip, .jar, .png, .jpg, etc.)
Tests added for symlink preservation and basic zip/unzip roundtrip.
The main use case for this is for a maven module we use that is for an npm
project and we want to also cache the node_modules directory, which didn't
perform well due to its size, and also had issues due to containing symlinks.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in
other changes.
- [ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [ ] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
