elharo commented on code in PR #416:
URL:
https://github.com/apache/maven-build-cache-extension/pull/416#discussion_r2698462950
##########
src/main/java/org/apache/maven/buildcache/xml/DtoUtils.java:
##########
@@ -109,14 +114,11 @@ public static Dependency createDependency(Artifact
artifact) {
}
public static void addProperty(
- CompletedExecution execution, String propertyName, Object value,
String baseDirPath, boolean tracked) {
+ CompletedExecution execution, String propertyName, Object value,
Path baseDirPath, boolean tracked) {
Review Comment:
Nine times out of ten you're correct. The tenth time things break.
Dependencies outside a monorepo are not predictable or even sane.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
