kwin commented on code in PR #1755:
URL: https://github.com/apache/maven-resolver/pull/1755#discussion_r2699598995
##########
maven-resolver-test-http/src/main/java/org/eclipse/aether/internal/test/util/http/HttpTransporterTest.java:
##########
@@ -991,7 +992,7 @@ protected void testPut_ProxyAuthenticated() throws
Exception {
transporter.put(task);
assertEquals(0L, listener.getDataOffset());
assertEquals(6L, listener.getDataLength());
- assertEquals(1, listener.getStartedCount());
+ assertTrue(listener.getStartedCount() > 0 &&
listener.getStartedCount() <= 2, "Started count: " +
listener.getStartedCount());
Review Comment:
But that way you don't get real results, e.g. progress reported on the
listener is not upload progress but copy progress to the temp file. I consider
this worse than having different values for the started count. Not sure what
the started count is used for potentially by consumers, but obviously retries
may differ i.e. it is expected to have different numbers depending on the
transport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
