Re: [PR] Support conditional resources from skins [maven-doxia-sitetools]

Fri, 30 Jan 2026 08:43:51 -0800 


kwin commented on code in PR #610:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/610#discussion_r2747100479


##########
doxia-skin-model/src/main/mdo/skin.mdo:
##########
@@ -97,5 +107,32 @@ under the License.
         </field>
       </fields>
     </class>
+    <class java.clone="deep">
+      <name>ResourceCondition</name>
+      <version>2.1.0+</version>
+      <description>Describes the condition for including a specific Skin 
resource.</description>
+      <fields>
+        <field xml.tagName="resource-name">
+          <name>resourceName</name>
+          <version>2.1.0+</version>
+          <type>String</type>
+          <description><![CDATA[
+            The name of the resource to which this condition applies. Refers 
to the path within the JAR (i.e. must always use "/" as separator and must not 
start with a slash).
+            ]]>
+          </description>
+          <required>true</required>
+        </field>
+        <field xml.tagName="vtl-condition">
+          <name>vtlCondition</name>
+          <version>2.1.0+</version>
+          <type>String</type>
+          <description><![CDATA[
+            The Velocity (VTL) expression to be evaluated to decide if the 
resource should be included. Only if the condition evaluates to true, the 
resource will be included.

Review Comment:
   The whole context within Doxia is a [Velocity context 
only](https://github.com/apache/maven-doxia-sitetools/blob/0f79ba1c1dad16d1b001a09fdc7eafd1049792d5/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L481).
 Nowhere else in Doxia you can rely any other scripting language. I don't want 
to come up with something more generic as I don't see the need here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to