HannesWell commented on code in PR #144: URL: https://github.com/apache/maven-toolchains-plugin/pull/144#discussion_r2979758579
########## src/main/java/org/apache/maven/plugins/toolchain/jdk/SelectJdkToolchainMojo.java: ########## Review Comment: I think printing the final decision makes sense. But with what's now all info I believe it might be a little bit too verbose for the standard log level case. My suggestion would be to either have this an info or - https://github.com/apache/maven-toolchains-plugin/blob/df2ecabc92c531cd29bf6020dc598bdb8d266ddf/src/main/java/org/apache/maven/plugins/toolchain/jdk/SelectJdkToolchainMojo.java#L198 - https://github.com/apache/maven-toolchains-plugin/blob/df2ecabc92c531cd29bf6020dc598bdb8d266ddf/src/main/java/org/apache/maven/plugins/toolchain/jdk/SelectJdkToolchainMojo.java#L210 What I like about the latter two is that one can derive from the printout the origin of the toolchain. On the other hand, the former is more clear that it's the final decision (especially after I've adjusted the printout a bit). To get the best from both world, we could add a variable that captures the origin and prints it as part of the final decision message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
