slawekjaranowski commented on code in PR #133:
URL:
https://github.com/apache/maven-doxia-converter/pull/133#discussion_r3016225197
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -357,9 +357,14 @@ public void convert(InputFileWrapper input,
OutputFileWrapper output)
+ input.getFormat().getExtension() + " found in
directory " + input.getFile());
}
for (File f : files) {
- File relativeOutputDirectory = new File(
-
PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
- convert(f, input.getEncoding(), input.getFormat(), output,
relativeOutputDirectory);
+ try {
+ File relativeOutputDirectory = new File(
+
PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
+ convert(f, input.getEncoding(), input.getFormat(),
output, relativeOutputDirectory);
+ } catch (Exception e) {
Review Comment:
Do we need to catch global exception? Is there a specific exception to catch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
