mirkoalicastro opened a new pull request, #3342:
URL: https://github.com/apache/maven-surefire/pull/3342
When `rerunFailingTestsCount` is used with JUnit Platform `@Suite`, tests
from different classes that share a method name are merged under the Suite
class name. It causes real failures to be misclassified as flakes. With the
changes in the PR, `findTopParent()` now stops at engine boundaries (parents
with no `ClassSource`), correctly attributing tests to their actual class while
preserving `@Nested`.
- [x] New unit test added
- [x] Verified with the small project shared in the original issue: build
correctly fails after fix
-------
Following this checklist to help us incorporate your contribution quickly
and easily:
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
