kwin commented on code in PR #1261:
URL:
https://github.com/apache/maven-site-plugin/pull/1261#discussion_r3072306317
##########
src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java:
##########
@@ -128,13 +128,7 @@ public Sink createSink(File outputDirectory, String
outputName) {
document = document.substring(0, document.lastIndexOf('.'));
DocumentRenderingContext subSinkContext = new
DocumentRenderingContext(
- docRenderingContext.getBasedir(),
- docRenderingContext.getBasedirRelativePath(),
- document,
- docRenderingContext.getParserId(),
- docRenderingContext.getExtension(),
- docRenderingContext.isEditable(),
- docRenderingContext.getGenerator());
+ docRenderingContext.getBasedir(), document,
docRenderingContext.getGenerator());
Review Comment:
All other arguments are `null` or false anyhow for report generated
documents, please look at the javadoc of the constructors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
