cstamas commented on code in PR #11967:
URL: https://github.com/apache/maven/pull/11967#discussion_r3112525857
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -214,8 +218,18 @@ public class DefaultRepositorySystemSessionFactory {
private final InternalScopeManager scopeManager = new
ScopeManagerImpl(Maven3ScopeManagerConfiguration.INSTANCE);
+ /**
+ * For legacy consumers; hopefully nobody.
+ */
+ @Deprecated
+ public DefaultRepositorySystemSession
newRepositorySession(MavenExecutionRequest request) {
+ return new DefaultRepositorySystemSession(
+ newRepositorySessionBuilder(request).build());
+ }
+
@SuppressWarnings("checkstyle:methodlength")
- public RepositorySystemSession.SessionBuilder
newRepositorySession(MavenExecutionRequest request) {
+ @Override
+ public RepositorySystemSession.SessionBuilder
newRepositorySessionBuilder(MavenExecutionRequest request) {
Review Comment:
Make new method `private`. nobody should within Maven create new session (I
think)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
