nils-christian commented on PR #3347: URL: https://github.com/apache/maven-surefire/pull/3347#issuecomment-4306402126
Hi @olamy , Thank you. Unfortunately it seems that the issue becomes a rabbit hole. One of the tests (ArchUnit4IT) seems to rely on the previous (wrong) behaviour, where the display name was always used. The other failing tests indicate that the "sourceText" attribute is actually overloaded with semantic. The RunListenerAdapter fills the "displayName" attribute (which becomes "sourceText" in createReportEntry) with different values. For a non-nested test both the class name and the display name are filled based on the source. For a nested test the class name is filled with the name of the top class, but the display name is the one of the nested class. This also means that we would change the behaviour with our fix, as we now no longer write the nested class name (from "sourceText") into the report. Instead we write the top class name (or its display name) into the report. This would very likely break with the expectation of some clients. At the moment I am unsure how to continue with this bug. I still think that the original fix is correct, but the implementation of the adapter is, well, weird in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
