Will-thom opened a new pull request, #12136:
URL: https://github.com/apache/maven/pull/12136
Fixes apache/maven#11882.
This updates profile activation condition tokenization so logical operators
remain valid when separated by line breaks or other whitespace, such as
CDATA-formatted conditions.
Changes:
- Treat all Java whitespace as token separators in activation conditions.
- Tokenize logical && and || operators explicitly.
- Add parser/profile activator coverage for multiline and mixed-whitespace
logical expressions.
- Add a model-building fixture covering multiline CDATA activation
conditions.
Verification:
- `mvn -pl impl/maven-impl -am
'-Dtest=ConditionParserTest,ConditionProfileActivatorTest,ComplexActivationTest'
'-Dsurefire.failIfNoSpecifiedTests=false' test`
- Tests run: 62, Failures: 0, Errors: 0, Skipped: 3
- `git diff --check`
Additional local validation notes:
- Full IT suite was attempted locally. On Windows, remaining failure was
environment-specific symlink privilege in
`MavenITmng8400CanonicalMavenHomeTest`.
- Docker/Linux validation was also attempted; unrelated IT failures were
triaged/rerun where practical, but a final clean full run was killed due local
disk/memory limits. The tests directly covering this change pass consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
