[
http://jira.codehaus.org/browse/MASSEMBLY-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_119938
]
Jelte van der Hoek commented on MASSEMBLY-257:
----------------------------------------------
For what it's worth, here's a new patch based on current trunk:
{noformat}
Index:
maven-assembly-plugin/src/main/java/org/apache/maven/plugin/assembly/format/FileFormatter.java
===================================================================
---
maven-assembly-plugin/src/main/java/org/apache/maven/plugin/assembly/format/FileFormatter.java
(revision 612068)
+++
maven-assembly-plugin/src/main/java/org/apache/maven/plugin/assembly/format/FileFormatter.java
(working copy)
@@ -79,6 +79,12 @@
{
File result = source;
+ // MASSEMBLY-257: bail out if there is nothing to change.
+ if( !filter && AssemblyFileUtils.getLineEndingCharacters(
lineEnding )==null )
+ {
+ return result;
+ }
+
AssemblyFileUtils.verifyTempDirectoryAvailability( tempRoot, logger );
{format}
> OutOfMemoryError when assembling large binary file
> --------------------------------------------------
>
> Key: MASSEMBLY-257
> URL: http://jira.codehaus.org/browse/MASSEMBLY-257
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Reporter: Jelte van der Hoek
> Attachments: fileitem-oome.patch
>
>
> The assembly phase reads all files into a single String, irrespective of
> whether they need filtering or not.
> This makes it unable to handle large binary files in an assembly.
> The quick fix for this is to not read the file at all if there is no
> 'lineEnding' nor 'filtered' option set.
> (The long fix would be to not read the file that way)
> Patch against 2.2-beta-1 attached (most of the patch changes .
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
