ascheman commented on PR #268: URL: https://github.com/apache/maven-source-plugin/pull/268#issuecomment-4642338070
Verified locally that this PR is the right plugin-side fix, and that the residual failures are entirely on the Maven core side (with the fix already merged upstream, awaiting next release): | Plugin source | Maven | Pass / Fail | |---|---|---| | master HEAD | rc-5 | 5 / 19 | | master HEAD | 4-master | 5 / 19 | | this PR | rc-5 | 20 / 4 | | this PR | 4-master | 23 / 1 | (`4-master` is `apache/maven` master HEAD at `a166e3fa`.) The 4 residual failures under rc-5 with this PR applied are the `outputDirectory == null` family (`MSOURCES-95`, `jar-includes-excludes`, `reproducible`, `MSOURCES-140`) — the `EnhancedCompositeBeanHelper.ACCESSIBLE_FIELD_CACHE` leak from apache/maven#11441, fixed by apache/maven#11425 (master, merged 2025-11-12) and apache/maven#11433 (maven-4.0.x backport, merged 2025-11-13). Both landed after rc-5 was tagged, so the residuals will disappear with rc-6 / GA. The 1 residual under 4-master is `MSOURCES-140`, a pre-existing Groovy verify-script regex bug (unescaped `"+ File.separator +"`), unrelated to the rc-5 work. The `CONFLICTING` status looks like a trivial rebase against current master. Happy to help if useful — anything else blocking review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
