alascbio opened a new pull request, #497:
URL: https://github.com/apache/maven-build-cache-extension/pull/497
Description
At the moment, the build cache extension supports
maven.build.cache.skipCache as a module-level property in pom.xml,
allowing specific modules to skip cache lookup.
However, maven.build.cache.skipSave does not currently behave the same way:
it can be set from the CLI, but not as a module-level property.
This creates an inconsistency in multi-module builds.
A concrete issue is that a module can be configured with:
<properties>
<maven.build.cache.skipCache>true</maven.build.cache.skipCache>
</properties>
to avoid reading from the cache, while still writing new entries to the
cache at the end of the build.
In practice, this means a module can be excluded from cache lookup but still
update the cache, which is not always desirable.
Expected behavior
Support the following in module pom.xml:
<properties>
<maven.build.cache.skipSave>true</maven.build.cache.skipSave>
</properties>
When set on a module, this property should prevent cache writes for that
module,
while still allowing cache reads unless maven.build.cache.skipCache=true is
also set.
This would make skipSave consistent with the existing module-level behavior
of skipCache.
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Your pull request should address just one issue, without pulling in
other changes.
- [X] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [X] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [X] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
