Hiteshsai007 commented on PR #12332: URL: https://github.com/apache/maven/pull/12332#issuecomment-4778112122
It looks like the `windows-latest` integration tests are still failing. I've double-checked my changes locally, and all the tests we modified/added (`ConditionProfileActivatorTest` and `ExecutableFinderTest`) pass successfully on Windows. Since the `executable()` function isn't used anywhere in the current `maven-core-its` integration tests, this code shouldn't be altering any existing behavior. It's highly likely that this failure is stemming from recent changes to the `master` branch (such as the recent default to `JdkTransporter`) which GitHub Actions merges into the PR branch during the build. Since the code changes themselves have been approved, is this something that blocks the merge, or can it be merged as-is while the `windows-latest` test flakiness on `master` is investigated separately? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
