Copilot commented on code in PR #1602: URL: https://github.com/apache/maven-site/pull/1602#discussion_r3459747447
########## content/markdown/guides/mini/guide-resolver-transport.md: ########## @@ -148,8 +148,7 @@ Configuration can be provided on global level as properties in `settings.xml` </settings> ``` -**NOTICE** -- only profiles activated by `settings/activeProfiles` will be taken for consideration - you can not use `profile/activation` in such case +**NOTICE:** Only profiles activated by `settings/activeProfiles` (the explicit list at the bottom of `settings.xml`) are honored here, or by CLI `-P <id>`. Profiles activated through `<activation>` conditions in the profile itself (`<activeByDefault>`, `<jdk>`, `<os>`, `<property>`, `<file>`) are **not** taken into account for the resolver session config -- the resolver session is built before Maven evaluates those conditions. Review Comment: This NOTICE is a single very long line/sentence; it’s hard to scan in rendered docs and in diffs. Consider splitting into two (or more) sentences and/or reintroducing a short bullet list for the enumerated activation types to improve readability without changing meaning. ########## content/markdown/guides/mini/guide-resolver-transport.md: ########## @@ -148,8 +148,7 @@ Configuration can be provided on global level as properties in `settings.xml` </settings> ``` -**NOTICE** -- only profiles activated by `settings/activeProfiles` will be taken for consideration - you can not use `profile/activation` in such case +**NOTICE:** Only profiles activated by `settings/activeProfiles` (the explicit list at the bottom of `settings.xml`) are honored here, or by CLI `-P <id>`. Profiles activated through `<activation>` conditions in the profile itself (`<activeByDefault>`, `<jdk>`, `<os>`, `<property>`, `<file>`) are **not** taken into account for the resolver session config -- the resolver session is built before Maven evaluates those conditions. You can also use environment variable `MAVEN_OPTS` ot `MAVEN_ARGS` Review Comment: Typo: 'ot' should be 'or'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
