elharo opened a new issue, #398:
URL: https://github.com/apache/maven-shared-utils/issues/398

   In `CommandLineUtils`, the `call()` method calls `waitUntilDone()` on 
`inputFeeder`, `outputPumper`, and `errorPumper` sequentially (lines 298-303). 
If the first call throws (e.g., `InterruptedException`), the remaining pumpers 
are never waited on, leaving their threads potentially running.
   
   The commented-out code above (lines 277-297) shows the original author 
intended a try-finally chain, but it was disabled.
   
   Fix: wrap the calls in a try-finally to ensure all pumpers are waited on 
even when an earlier one throws.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to