kwin commented on code in PR #1762:
URL: https://github.com/apache/maven-resolver/pull/1762#discussion_r3519561484
##########
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/TransportListener.java:
##########
@@ -34,19 +35,39 @@
*/
public abstract class TransportListener {
+ public interface TransportPropertyKey {}
+
/**
* Enables subclassing.
*/
protected TransportListener() {}
+ /**
+ * Notifies the listener about the start of the data transfer. This event
may arise more than once if the transfer
+ * needs to be restarted (e.g. after an authentication failure).
+ *
+ * @param dataOffset The byte offset in the resource at which the transfer
starts, must not be negative.
+ * @param dataLength The total number of bytes in the resource or {@code
-1} if the length is unknown.
+ * @param transportProperties The transport properties associated with
this transfer, may be empty. The keys are transporter specific and the value
types are key specific.
+ * @throws TransferCancelledException If the transfer should be aborted.
+ * @since NEXT
+ */
+ public void transportStarted(
+ long dataOffset, long dataLength, Map<TransportPropertyKey,
Object> transportProperties)
+ throws TransferCancelledException {
+ transportStarted(dataOffset, dataLength);
+ }
+
/**
* Notifies the listener about the start of the data transfer. This event
may arise more than once if the transfer
Review Comment:
@cstamas Can you clarify how this is supposed to be used for HTTP GET and
HTTP PUT? For the former this is about receiving. For the latter is it support
to report progress on upload or receiving the response?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
