Hiteshsai007 opened a new pull request, #12416: URL: https://github.com/apache/maven/pull/12416
### Description This PR addresses [MNG-11147](https://github.com/apache/maven/issues/11147), fixing a regression in Maven 4 where version and `groupId` inference were skipped for dependencies declared within the `<dependencyManagement>` section of a BOM-packaged project. **How it works:** I updated the `transformFileToRaw` method within `DefaultModelBuilder` to ensure that `model.getDependencyManagement().getDependencies()` is processed with the same `inferDependencyVersion` and `inferDependencyGroupId` logic that is already applied to direct dependencies (`model.getDependencies()`). **Why this is necessary:** Previously, if a BOM subproject declared sibling reactor modules within its `<dependencyManagement>` block but omitted the `<version>` tags (expecting them to be resolved from the reactor), the transformation to the raw model would skip them entirely. This resulted in the installed consumer POM missing the required version tags for those managed dependencies. This change ensures that the reactor versions are properly inherited and written to the consumer POM. **Testing:** * Successfully verified the fix locally using the `bom-example` reproducer provided in the issue, confirming that the resulting consumer POM now contains the correctly inferred versions. * Formatted with `spotless:apply` and successfully passed all `maven-impl` unit tests. Note: Due to the complexity of simulating a full multi-module reactor state directly within `DefaultModelBuilderTest`, a standalone unit test for this specific code path was omitted in favor of the reproducer validation. --- <!-- Please open pull requests against one of the following branches: - master — default target for all changes (new features + bug fixes). If the change should also go to maven-4.0.x, request a backport in the PR. - maven-3.10.x — target for 3.x changes (new features + bug fixes). If the change should also go to maven-3.9.x, request a backport in the PR. maven-3.9.x should receive only serious bug fixes, as it is approaching EOL. Backports are typically handled by maintainers; however, after agreement you may open a separate backport PR to the target maintenance branch. --> Following this checklist to help us incorporate your contribution quickly and easily: - [x] Your pull request should address just one issue, without pulling in other changes. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice. - [ ] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
