elharo commented on issue #511: URL: https://github.com/apache/maven-ear-plugin/issues/511#issuecomment-4877114411
After further analysis, this is **not a bug**. The `!` negation is correct. `MavenResourcesFiltering.filteredFileExtension()` returns: - `true` when the extension is **NOT** in the non-filtered list (file should be filtered) - `false` when the extension **IS** in the non-filtered list (file should NOT be filtered) So in `EarMojo.isNonFilteredExtension()`: ```java return !mavenResourcesFiltering.filteredFileExtension(fileName, nonFilteredFileExtensions); ``` - If extension IS in non-filtered list → `filteredFileExtension` returns `false` → `!false` = `true` → correct - If extension is NOT in non-filtered list → `filteredFileExtension` returns `true` → `!true` = `false` → correct The existing integration test `testProject047` confirms this works correctly (`.txt` files in `nonFilteredFileExtensions` are not filtered). Closing as not a bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
