elharo commented on code in PR #618:
URL: https://github.com/apache/maven-war-plugin/pull/618#discussion_r3523289256
##########
src/main/java/org/apache/maven/plugins/war/packaging/OverlayPackagingTask.java:
##########
@@ -112,7 +112,7 @@ protected File unpackOverlay(WarPackagingContext context,
Overlay overlay) throw
* @param overlay the overlay
* @return the temp directory for the overlay
*/
- protected File getOverlayTempDirectory(WarPackagingContext context,
Overlay overlay) {
+ protected File getOverlayTempDirectory(WarPackagingContext context,
Overlay overlay) throws MojoExecutionException {
Review Comment:
this is tricky because we don't want to change the signature here. maybe
remove this file from the pR and come back to it in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
