elharo opened a new issue, #621: URL: https://github.com/apache/maven-war-plugin/issues/621
## Bug Description `OverlayManager.compareOverlayWithArtifact()` at `src/main/java/org/apache/maven/plugins/war/overlay/OverlayManager.java` lines 205-206 uses `Objects.toString(overlay.getClassifier())` which converts a `null` classifier to the literal string `"null"` rather than `""`. The adjacent comment explicitly states that `null` and `""` should be treated as equal for classifier comparison (MWAR-241), but this code treats them as distinct. ## Impact Overlay-to-artifact matching fails when one side has a null classifier and the other has an empty string. ## Code ```java // Line 205-206 Objects.toString(overlay.getClassifier()) // When overlay.getClassifier() is null, this returns "null" not "" ``` ## Expected behavior Use `Objects.toString(overlay.getClassifier(), "")` so that null is treated as empty string, matching the documented intent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
