kwin opened a new issue, #1974:
URL: https://github.com/apache/maven-resolver/issues/1974

   ### New feature, improvement proposal
   
   Currently each connection being established via the UrlTransporter is 
unconditionally released for example in 
https://github.com/apache/maven-resolver/blob/45482a82ce0377d0c7a0d8fc343eeff6b94012ad/maven-resolver-transport-url/src/main/java/org/eclipse/aether/transport/url/UrlTransporter.java#L251.
 Although this is safe in terms of releasing the http connection it would also 
prevent connection pooling.
   
   Instead one should rather just close the returned input streams. Compare 
with the Javadoc in 
https://docs.oracle.com/javase/8/docs/api/java/net/HttpURLConnection.html.
   
   It is important though to close both 
[regular](https://docs.oracle.com/javase/8/docs/api/java/net/URLConnection.html#getInputStream--)
 and potentially also [error input 
stream](https://docs.oracle.com/javase/8/docs/api/java/net/HttpURLConnection.html#getErrorStream--).
   
   Particularly as TLS handshakes are expensive connection pooling usually has 
a big performance impact.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to