belingueres commented on code in PR #129:
URL: https://github.com/apache/maven-shared-jar/pull/129#discussion_r3611784288
##########
src/main/java/org/apache/maven/shared/jar/classes/JarClasses.java:
##########
@@ -57,10 +57,10 @@ public class JarClasses {
private boolean isDebugPresent;
/**
- * The highest JVM revision available in any class files. While the JAR
may work on earlier JVMs if particular
- * classes are not used, this is the minimum JVM that guarantees
compatibility.
+ * The highest Java class version available in any class files. While the
JAR may work on earlier JVMs if particular
+ * classes are not used, this is the minimum JVM version that guarantees
compatibility.
Review Comment:
The javadoc comment most probably is confusing. How about this comment:
```
/**
* The highest Java version required by any class in the JAR (e.g. "17" if
the newest
* class file version present corresponds to Java 17).
* <p>
* Because this is the highest requirement across all classes, it also
serves as the
* minimum JVM version needed to safely run the entire JAR. The JAR may
still happen
* to run on an older JVM if the classes requiring this version are never
invoked,
* but that isn't guaranteed.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
