gnodet commented on code in PR #509:
URL:
https://github.com/apache/maven-build-cache-extension/pull/509#discussion_r3612316626
##########
src/site/markdown/remote-cache.md:
##########
@@ -143,7 +143,8 @@ from Maven 3.9.1 and 4.0.0-alpha5, support of webdav has
been removed per defaul
You need to use the following extra configuration:
```bash
--Daether.connector.http.supportWebDav=true
+-Daether.transport.http.supportWebDav # mvn 3.10+
+-Daether.connector.http.supportWebDav # mvn 3.9
Review Comment:
**[Nit]** The previous version had `=true` (i.e.
`-Daether.connector.http.supportWebDav=true`). While Maven CLI treats bare
`-DpropName` as setting value `"true"`, users configuring this in POM
`<properties>` or `.mvn/maven.config` contexts need `=true` explicitly (since
`Boolean.parseBoolean("")` returns `false`). Adding `=true` back improves
copy-paste safety:
```suggestion
-Daether.transport.http.supportWebDav=true # mvn 3.10+
-Daether.connector.http.supportWebDav=true # mvn 3.9
```
##########
src/test/java/org/apache/maven/buildcache/its/Issue463Test.java:
##########
@@ -134,7 +134,8 @@ void
runnerBShouldHitRemoteCacheAfterRunnerAUploadsCompleteEntry() throws Verifi
verifier.setAutoclean(false);
verifier.addCliOption("--settings=" + settings);
// Allow Aether to create WebDAV collection (directory) hierarchy via
MKCOL
- verifier.setSystemProperty("aether.connector.http.supportWebDav",
"true");
+ verifier.setSystemProperty("aether.transport.http.supportWebDav",
"true"); // Maven 3.10+
+ verifier.setSystemProperty("aether.connector.http.supportWebDav",
"true"); // Maven 3.9
Review Comment:
**[Suggestion]** The dual-property pattern here is correct and consistently
applied across `BaselineDiffTest` and `SaveFinalRemoteTest`. However,
`RemoteCacheDavTest.java` (lines 156, 173) still only sets the Resolver 1
property (`aether.connector.http.supportWebDav`). Consider also updating
`RemoteCacheDavTest` with the Resolver 2 property for consistency — the current
mixed approach (explicit here, implicit via `maven.config` there) creates
fragility if someone later restructures the test project config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
