ascheman commented on code in PR #3398:
URL: https://github.com/apache/maven-surefire/pull/3398#discussion_r3636551839
##########
surefire-its/src/test/resources/surefire-1993-jpms-providing-modules/pom.xml:
##########
@@ -93,6 +93,14 @@
<artifactId>maven-failsafe-plugin</artifactId>
<version>${surefire.version}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <!-- explicit 3.5.1: the Maven 3.10.0(-rc-1) super-POM
pins 3.5.0, which
+ breaks modular JARs on Windows with JDK < 14
(plexus-archiver 4.10.4
+ NPE), see
https://github.com/apache/maven-jar-plugin/issues/555 -->
+ <version>3.5.1</version>
+ </plugin>
Review Comment:
The `<pluginManagement>` entry does apply to the default-bound `jar:jar`
executions of the child modules: project-level pluginManagement takes
precedence over the super-POM's. Empirically confirmed in the fixture build log
of `Surefire1993JpmsProvidingModulesIT` (Maven 3.10.0-rc-1): `--- jar:3.5.1:jar
(default-jar) @ studentservice-provider ---` and `--- jar:3.5.1:jar
(default-jar) @ application ---`. The now-green windows-jdk11 CI cell of this
PR confirms it end-to-end — that cell fails with an NPE exactly when a modular
fixture still uses jar-plugin 3.5.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
