Copilot commented on code in PR #188:
URL:
https://github.com/apache/maven-toolchains-plugin/pull/188#discussion_r3637904197
##########
src/site/apt/toolchains/jdk-discovery.apt.vm:
##########
@@ -121,7 +121,7 @@ mvn toolchains:select-jdk-toolchain
-Dtoolchain.jdk.version="[17,)" compile
* <<<env>>> / <<<toolchain.jdk.env>>>: the name of an environment variable
that the JDK toolchain must match
- The <<<useJdk>>> can be used to define whether the current JDK can be used
if it matches the requirements.
+ The <<<useJdk>>> property controls whether the current JDK is used when it
matches the requirements.
Review Comment:
This sentence refers to a `useJdk` property, but the actual
configuration/CLI parameter in the plugin is `toolchain.jdk.mode` (with values
`IfMatch`, `IfSame`, `Never`). As written, the docs are likely to mislead users
who try `-Dtoolchain.jdk.useJdk=...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
