gnodet commented on code in PR #2010:
URL: https://github.com/apache/maven-resolver/pull/2010#discussion_r3639439753
##########
src/site/markdown/creating-a-repository-system-session.md:
##########
@@ -35,12 +35,12 @@ import org.eclipse.aether.supplier.RepositorySystemSupplier;
...
private static RepositorySystemSession newSession( RepositorySystem system
)
{
- RepositorySystemSession.SessionBuilder sessionBuilder =
SessionBuilderSupplier.get();
+ RepositorySystemSession.SessionBuilder sessionBuilder =
system.createSessionBuilder();
LocalRepository localRepo = new LocalRepository( "target/local-repo" );
- sessionBuilder.setLocalRepositoryManager(
system.newLocalRepositoryManager( session, localRepo ) );
+ sessionBuilder.setLocalRepositoryManager(
system.newLocalRepositoryManager( sessionBuilder, localRepo ) );
- return session.build();
+ return sessionBuilder.build();
Review Comment:
This still won't compile: all three overloads of `newLocalRepositoryManager`
require a `RepositorySystemSession` as the first argument, and `SessionBuilder`
does not extend `RepositorySystemSession`.
The `SessionBuilder` API provides
`withLocalRepositories(LocalRepository...)` for exactly this purpose:
```suggestion
RepositorySystemSession.SessionBuilder sessionBuilder =
system.createSessionBuilder();
LocalRepository localRepo = new LocalRepository( "target/local-repo"
);
sessionBuilder.withLocalRepositories( localRepo );
return sessionBuilder.build();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
