ascheman commented on PR #12523:
URL: https://github.com/apache/maven/pull/12523#issuecomment-5061242536
Thanks @gnodet — the direction reads right to me. Treating the gh-11978
empty-for-unknown expectation as the anomaly (rather than scoping the
parse-time interpolation) restores Maven 3's literal-for-unknown behaviour
uniformly, which is what the cross-version repro showed 3.9.16 and 3.10.0-rc-1
both do. Preserving unresolved `${...}` at CLI parse time and letting
`PluginParameterExpressionEvaluator` resolve project/session context later at
mojo time is exactly the semantics
`-DaltDeploymentRepository=…file://${project.build.directory}/…` needs.
CI is green here including the ITs. I've gone ahead and set the `bug` label
and the `4.0.0-rc-6` milestone on this PR (matching #12507) so it's on the rc-6
radar — revert if you'd rather it not carry those. Happy to help with a
`maven-4.0.x` backport once this lands on master; the fix applied cleanly to
both lines when I tested it. Thanks again for carrying it over the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]