ascheman opened a new pull request, #12524:
URL: https://github.com/apache/maven/pull/12524
Backport of #12523 (fix for #12507) to the `maven-4.0.x` line, so the fix
ships in `4.0.0-rc-6`. cc @gnodet (confirmed on Slack).
The three commits from #12523 cherry-pick cleanly — the production fix is
byte-identical to what landed on `master`:
- **`Add failing IT for #12507`** — new
`MavenITgh12507CliParamNestedInterpolationTest`
- **`Fix #12507: dont wipe unresolved ${...} in -D values`** —
`BaseParser.populateUserProperties` passes `defaultsToEmpty=false`, preserving
unresolved `${...}` at CLI parse time so the plugin parameter expression
evaluator resolves project/session context later (Maven 3 semantics)
- **`Update gh-11978 IT to expect Maven 3 semantics for unknown
placeholders`** (@gnodet)
One backport-specific commit on top:
- **`Port gh-12507 IT to the 4.0.x test-harness API`** — the new IT was
written against master's newer test harness (Path-based `Verifier`, no-arg
`AbstractMavenIntegrationTestCase`); on `maven-4.0.x` the harness is
File/String-based and requires a version-range `super()` call. Ported
accordingly and gated `[4.0.0-rc-6,)` (the fix's first release; the built
`4.0.0-SNAPSHOT` satisfies the range, so the body runs rather than skips).
**Local verification** against a `maven-4.0.x` distribution built from this
branch (JDK 17):
```
MavenITgh12507CliParamNestedInterpolationTest Tests run: 2, Failures: 0,
Skipped: 0
MavenITgh11978PlaceholderInCliArgTest Tests run: 1, Failures: 0,
Skipped: 0
```
Both actually execute (not skipped by the version gate). Original authorship
preserved on the cherry-picked commits.
Refs #12507, #12523.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
