Copilot commented on code in PR #537:
URL: https://github.com/apache/maven-ear-plugin/pull/537#discussion_r3644981547
##########
src/site/apt/index.apt.vm:
##########
@@ -97,7 +97,7 @@ ${project.name}
EAR Plugin has two goals:
- * {{{./ear-mojo.html}ear:ear}} generates J2EE Enterprise Archive (EAR) files.
+ * {{{./ear-mojo.html}ear:ear}} generates Jakarta EE Enterprise Archive (EAR)
files.
Review Comment:
The goals overview line says the plugin generates “Jakarta EE” EAR files,
but earlier in the same document it says it generates “Java EE” EAR files (line
31). This inconsistency is confusing; consider wording that covers both,
matching the intro.
##########
src/site/apt/examples/eclipse-and-maven-integration.apt.vm:
##########
@@ -30,7 +30,7 @@ Eclipse and Maven Integration (without m2e)
If you have used <<<mvn eclipse:eclipse>>> to generate the metadata for an
EAR project, it will want the <<<application.xml>>> file in the
<<<src/main/application/META-INF>>> directory.
- If you edit <<<application.xml>>> using the WTP based Application Deployment
Descriptor editor, it will use the name of the projects (Web, EJB etc) as the
name of the modules. Here is an example:
+ If you edit <<<application.xml>>> using the WTP based Application Deployment
Descriptor editor, it will use the names of the projects (Web, EJB etc) as the
name of the modules. Here is an example:
Review Comment:
Subject/number agreement is off: the sentence uses “names” but then says “as
the name of the modules”.
##########
src/site/apt/examples/excluding-files-from-ear.apt.vm:
##########
@@ -206,4 +206,4 @@ Excluding Files From the EAR
</dependency>
+---------------------
- As you can see <<<exclusions>>> support wildcard expressions, so you can
have fast and full control over all the dependencies you'd like to exclude.
\ No newline at end of file
+ As you can see <<<exclusions>>> support wildcard expressions, so you can
have fine-grained control over all the dependencies you'd like to exclude.
Review Comment:
This line has trailing whitespace at the end, which can create noisy diffs
and may trip whitespace-checking tooling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
