cstamas commented on PR #436:
URL: https://github.com/apache/maven-wrapper/pull/436#issuecomment-5074604571

   Yes, that looks good as well, but several remarks:
   * getHighestVersion may return SNAPSHOT, hence the loop in my code
   * version may be just version, so all this is not needed (the logic in my 
code), but you are right, this mojo is invoked by user, no need to complicate 
or to be "fast". Simple is better.
   
   Otherwise, yes, this is the right way, no need to fiddle with XML parsing 
etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to