gnodet commented on PR #12532: URL: https://github.com/apache/maven/pull/12532#issuecomment-5075445844
Thanks for the review! Addressed all three points: 1. **`buildElementPath` unused `child` parameter** — Removed the unused parameter. Method now takes only the parent element. (80b938e) 2. **`getPluginMigrationsMap()` rebuilt on every call** — Hoisted to a `static final` field initialized once from `PLUGIN_MIGRATIONS`. (80b938e) 3. **`getPluginUpgradesMap()` dedup** — Already done in c88b27e (derives from `PLUGIN_UPGRADES` list via stream, eliminating the previous hand-maintained duplicate map). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
