wilx opened a new pull request, #1343:
URL: https://github.com/apache/maven-assembly-plugin/pull/1343
Following this checklist to help us incorporate your
contribution quickly and easily:
This PR strengthens integration coverage for documented module-set binary
behavior without changing production code.
It verifies that:
- `includeDependencies=false` excludes an actual runtime dependency while
retaining selected module artifacts;
- `attachmentClassifier` selects an attached classified artifact instead of
the module's main artifact; and
- the implied dependency set includes an artifact that is reachable only
transitively.
Validation:
- `mvn verify` — 268 tests passed.
- `mvn -Prun-its verify` — 151 Invoker projects passed.
- The affected Invoker projects also passed focused runs with Maven 3.6.3,
Maven 3.9.16, and Maven 4.0.0-rc-5.
- [ ] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
