slachiewicz commented on PR #905: URL: https://github.com/apache/maven-wagon/pull/905#issuecomment-5225949683
Second commit added, and it turned up a code defect worth knowing about before review. Writing the corrected `BasicAuthScope` javadoc meant actually reading the realm branch, and both arms of its `if`/`else` assign the same thing — so `<realm>ANY</realm>` sets the literal string `ANY` rather than `AuthScope.ANY_REALM`, while host and port next to it map `ANY` correctly. Filed as #910. The code is untouched here; fixing it is a behaviour change and belongs in its own PR. That also means this PR's first commit had it wrong: `http-configuration.md` said each of host, port and realm accepts `ANY` to mean "match anything". The second commit corrects that to describe the asymmetry, keeps the all-`ANY` example with a note that it only works through the early short circuit, and adds an example showing that widening host and port means omitting realm. Also in this commit: a developer-guide subsection on running the TCK classes rather than subclassing them from your own package. The use-case id is recovered by walking the stack for the last method before the first frame outside `getClass().getPackage().getName()`, so a consumer subclassing from elsewhere gets `Cannot run test: null` on every case, each treated as unsupported — a suite that goes green without testing anything. Site still builds; the new heading and the corrected text were checked in the rendered HTML. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
