slachiewicz commented on PR #628: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/628#issuecomment-5227045293
Flagging an overlap I created: I opened #650 today to remove `maven-compat` from this plugin without first checking for an existing PR, and it duplicates most of this one — 19 of its 20 changed files are the same files here, and it reaches the same solution independently (resolver `VersionRangeRequest`, with the artifact built from `ArtifactHandlerManager` + `DefaultArtifact`). This PR came first and should land first; I have said so on #650 and will rebase mine down to the leftover `pom.xml` change once this merges, or close it. Two findings from verifying the same code path, in case they are useful here: **Behaviour change worth a release note.** `retrieveAvailableVersions` returned snapshots and Maven's `VersionRange.containsVersion` accepts them, so a SNAPSHOT could win a range like `[1.0,)`. Resolver's `DefaultVersionRangeResolver` requests `RELEASE`-nature metadata unless a range bound is itself a snapshot, so snapshots are now excluded. It aligns the report with Maven's own resolution, but users may see a different version rendered. **Coverage gap for that change.** `DependencyManagementReportTest` pins a plain version, so the range branch never runs in unit tests. The `full-pom` IT does exercise it and its log confirms the resolution, but no fixture has a range whose matches include a snapshot — so that specific difference is reasoned, not observed. Independent arrival at the same design is reassuring for the approach here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
