pzygielo commented on code in PR #405:
URL: https://github.com/apache/maven-help-plugin/pull/405#discussion_r3741785161
##########
src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java:
##########
@@ -197,6 +197,16 @@ private void writeEffectivePom(MavenProject project,
XMLWriter writer) throws Mo
// This removes the XML declaration written by MavenXpp3Writer
String effectivePom = prettyFormat(sWriter.toString(), null, true);
+ // MavenXpp3Writer omits packaging when it is null or "jar" (the
default).
+ // Ensure it is always present so users can see the effective
packaging value.
+ if (pom.getPackaging() == null || "jar".equals(pom.getPackaging())) {
+ String packaging = pom.getPackaging() != null ? pom.getPackaging()
: project.getPackaging();
+ String packagingTag = " <packaging>" + packaging + "</packaging>";
+ if (!effectivePom.contains(packagingTag)) {
+ effectivePom = effectivePom.replace("</version>" + LS,
"</version>" + LS + packagingTag + LS);
Review Comment:
If given project has parent, like
```xml
<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd";>
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>...</groupId>
<artifactId>...</artifactId>
<version>0.1-SNAPSHOT</version>
</parent>
<groupId>...</groupId>
<artifactId>..</artifactId>
<version>0.1-SNAPSHOT</version>
...
```
which `</version>` will be replaced in l. 206?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
